Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: remove deprecated phasetype methods #927

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner February 22, 2024 17:59
@codecov-commenter
Copy link

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (4a4fc76) 33.61% compared to head (935a1a2) 33.61%.
Report is 1 commits behind head on master.

Files Patch % Lines
.../propertyGenerator/OLGApropertyTableGenerator.java 0.00% 5 Missing ⚠️
...m/thermodynamicOperations/flashOps/SolidFlash.java 0.00% 4 Missing ⚠️
.../thermodynamicOperations/flashOps/SolidFlash1.java 0.00% 4 Missing ⚠️
...thermodynamicOperations/flashOps/SolidFlash12.java 0.00% 4 Missing ⚠️
...qsim/MathLib/nonLinearSolver/sysNewtonRhapson.java 0.00% 2 Missing ⚠️
...ertyGenerator/OLGApropertyTableGeneratorWater.java 0.00% 2 Missing ⚠️
...rator/OLGApropertyTableGeneratorWaterStudents.java 0.00% 2 Missing ⚠️
...tor/OLGApropertyTableGeneratorWaterStudentsPH.java 0.00% 2 Missing ⚠️
...qsim/thermodynamicOperations/flashOps/TPflash.java 83.33% 1 Missing ⚠️
...icOperations/flashOps/saturationOps/FreezeOut.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #927   +/-   ##
=========================================
  Coverage     33.61%   33.61%           
+ Complexity     5127     5126    -1     
=========================================
  Files           701      701           
  Lines         69847    69830   -17     
  Branches       7996     7994    -2     
=========================================
- Hits          23476    23474    -2     
+ Misses        44895    44880   -15     
  Partials       1476     1476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update👍

@asmfstatoil asmfstatoil merged commit dcf8d1b into equinor:master Feb 23, 2024
5 checks passed
@asmfstatoil asmfstatoil deleted the rm_deprecated_phasetype branch February 23, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants