Skip to content

Commit

Permalink
Rounded cpu and memory resources (#685)
Browse files Browse the repository at this point in the history
  • Loading branch information
satr authored Oct 2, 2024
1 parent 4ce43bb commit 02f2e2d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
5 changes: 3 additions & 2 deletions api/metrics/prometheus_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package metrics

import (
"context"
"math"
"regexp"
"time"

Expand Down Expand Up @@ -97,14 +98,14 @@ func parseQueryDuration(duration string, defaultValue string) (time.Duration, st

func getCpuMetricValue(ctx context.Context, queryResults map[internal.QueryName]prometheusModel.Value, queryName internal.QueryName) *float64 {
if value, ok := getMetricsValue(ctx, queryResults, queryName); ok {
return pointers.Ptr(value)
return pointers.Ptr(math.Round(value*1e6) / 1e6)
}
return nil
}

func getMemoryMetricValue(ctx context.Context, queryResults map[internal.QueryName]prometheusModel.Value, queryName internal.QueryName) *float64 {
if value, ok := getMetricsValue(ctx, queryResults, queryName); ok {
return pointers.Ptr(value)
return pointers.Ptr(math.Round(value))
}
return nil
}
Expand Down
12 changes: 6 additions & 6 deletions api/metrics/prometheus_handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,14 +160,14 @@ func getExpectedUsedResources(warnings ...string) *applicationModels.UsedResourc
return &applicationModels.UsedResources{
Warnings: warnings,
CPU: &applicationModels.UsedResource{
Min: pointers.Ptr(0.02520196),
Avg: pointers.Ptr(0.0498679316),
Max: pointers.Ptr(0.134699898),
Min: pointers.Ptr(0.025202),
Avg: pointers.Ptr(0.049868),
Max: pointers.Ptr(0.1347),
},
Memory: &applicationModels.UsedResource{
Min: pointers.Ptr(168965.6892544),
Avg: pointers.Ptr(241308.93398770998),
Max: pointers.Ptr(358023.69331542),
Min: pointers.Ptr(168966.0),
Avg: pointers.Ptr(241309.0),
Max: pointers.Ptr(358024.0),
},
}
}

0 comments on commit 02f2e2d

Please sign in to comment.