-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix imports for configs #529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know if we have a system for dependency management that we use, but i feel like this is an API change of ert, and hence we should bump the version of ert as a dependency when updating these import lines - which of course requires merging ert first, and making a new tag / release, and us having ert as a versioned requirement in this project...
yes i see we have ert with a min version in setup.py
i suggest we wait for the ert PR to be merged, make a new tag, and then bump the min version here before merging
Not sure there is a formal process around this until we propose releases for komodo |
in my time as a release manager, i did not see this mentioned or formalized anywhere. but i guess it doesn't need to be formal - would you agree with the following steps:
|
the test is failing with
from the logs, we can see it installs
so it looks like we have to bump the dependencies before the tests can pass - i guess this is a good way of formalizing it 😅 |
I guess a new tag on ert will do it as semeio then downloads the latest ? |
523ce1c
to
81dce04
Compare
81dce04
to
5984e48
Compare
No description provided.