Fixed index order bugs #575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddvarlia
force-pushed
the
fix-non-adaptive-index-order
branch
from
e551ed0
to
d2d6110
Compare
dafeda
force-pushed
the
fix-non-adaptive-index-order
branch
from
b7424ac
to
8eff858
Compare
oddvarlia
force-pushed
the
fix-non-adaptive-index-order
branch
from
722094c
to
329fef7
Compare
oyvindeide
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Looks like a good improvement! Seems there are some stray comments. There are also some added features that are not tested. Optionally they could be added in another PR. Seems like the bug which is being fixed here has test coverage already in the form of a snapshot test?
oddvarlia
force-pushed
the
fix-non-adaptive-index-order
branch
2 times, most recently
from
a8b6f5c
to
3ee8e16
Compare
oyvindeide
reviewed
Dec 20, 2023
oddvarlia
force-pushed
the
fix-non-adaptive-index-order
branch
4 times, most recently
from
17c5848
to
c289b19
Compare
Minor edits in local_script_lib.py
Added output of scaling factors when using SURFACE in ERT in test_integation.py
oddvarlia
force-pushed
the
fix-non-adaptive-index-order
branch
from
c289b19
to
28ccd14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix grid index order bug in local_script_lib.py
Close issue #576