Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Well Completion Module #203

Merged
merged 24 commits into from
Aug 31, 2023

Conversation

jorgenherje
Copy link
Collaborator

@jorgenherje jorgenherje commented Jun 26, 2023

Initial implementation of WellCompletions module, with some hard coded well completion data in back-end. Awaiting decision of data on SUMO: well attributes and stratigraphy.

Additional functionality is to be added later on, as it awaits sumo data, conversion of components as SmartNodeSelector, etc.

NOTE: Dependent on new package well-completions-plot in webviz-subsurface-components, created in PR: equinor/webviz-subsurface-components#1629


Remaining data:

  • Well attributes from cloud (SUMO or elsewhere?)
  • Stratigraphy from cloud (SUMO or elsewhere?)

Issue created: #256

Remaining functionality:

  • Consider adding dropdowns for time steps if number of available time steps becomes large (slider might be inaccurate/bad functionality with many time steps).
  • Wells per page/horizontal slider functionality for plot
  • Sort/Group by Attributes functionality (view control in old plugin)
  • Zone selection
  • Filter by attributes (smart node selector in filter of old plugin)

Issue created: #255


Closes: #191

@jorgenherje jorgenherje added the enhancement New feature or request label Jun 26, 2023
@jorgenherje jorgenherje self-assigned this Jun 26, 2023
- Get data from Sumo (some missing dummy data is added)
- Convert from Sumo to json data for front-end
- Add accessor-class for creating plot data for visualization
@jorgenherje jorgenherje changed the title Initial implementation of Well Completion Module Well Completion Module Aug 4, 2023
@jorgenherje jorgenherje force-pushed the 191-well-completion-module branch 2 times, most recently from c14072a to 93cdd2b Compare August 7, 2023 13:40
- Add functionality
- Update well completion data types naming for api
@jorgenherje jorgenherje marked this pull request as ready for review August 10, 2023 09:29
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, otherwise, it looks good.

.gitignore Outdated Show resolved Hide resolved
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Some minor comments.

frontend/src/modules/WellCompletion/settings.tsx Outdated Show resolved Hide resolved
frontend/src/modules/WellCompletion/state.ts Outdated Show resolved Hide resolved
frontend/src/modules/WellCompletion/settings.tsx Outdated Show resolved Hide resolved
frontend/src/modules/WellCompletion/settings.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jorgenherje jorgenherje merged commit 8df6ba1 into equinor:main Aug 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

Well completion module
2 participants