-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Well Completion Module #203
Well Completion Module #203
Conversation
ffda86c
to
b4cd344
Compare
b4cd344
to
cf4f5e1
Compare
fc8efe4
to
3a57712
Compare
- Get data from Sumo (some missing dummy data is added) - Convert from Sumo to json data for front-end - Add accessor-class for creating plot data for visualization
63f76fa
to
2c0f174
Compare
c14072a
to
93cdd2b
Compare
- Add functionality - Update well completion data types naming for api
93cdd2b
to
38a04ea
Compare
6c7a7f3
to
1426c43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, otherwise, it looks good.
frontend/src/modules/WellCompletion/wellCompletionsDataAccessor.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/WellCompletion/wellCompletionsDataAccessor.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/WellCompletion/wellCompletionsDataAccessor.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/WellCompletion/wellCompletionsDataAccessor.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/WellCompletion/wellCompletionsDataAccessor.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 Some minor comments.
2434ede
to
7c86257
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Initial implementation of WellCompletions module, with some hard coded well completion data in back-end. Awaiting decision of data on SUMO: well attributes and stratigraphy.
Additional functionality is to be added later on, as it awaits sumo data, conversion of components as SmartNodeSelector, etc.
NOTE: Dependent on new package
well-completions-plot
inwebviz-subsurface-components
, created in PR: equinor/webviz-subsurface-components#1629Remaining data:
Issue created: #256
Remaining functionality:
Issue created: #255
Closes: #191