Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for renaming/refactoring of functions/classes/files related to Parameters and Sensitivities #412

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rubenthoms
Copy link
Collaborator

@rubenthoms rubenthoms commented Oct 9, 2023

The current function calls for getting a list of parameters from an ensemble does not really add to readability.

image

I suggest to (in accordance to implemented patterns around EnsembleSet):

  • Rename EnsembleParameters to EnsembleParameterSet (also the related getter function and member)
  • Moving ParameterIdent into its own file

@rubenthoms rubenthoms self-assigned this Oct 9, 2023
@rubenthoms rubenthoms changed the title Proposal for renaming/refactoring of functions/classes/files related to Parameters Proposal for renaming/refactoring of functions/classes/files related to Parameters and Sensitivities Oct 10, 2023
@rubenthoms rubenthoms marked this pull request as draft October 12, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant