-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade realization filtering #741
Open
jorgenherje
wants to merge
37
commits into
equinor:main
Choose a base branch
from
jorgenherje:improve-realization-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,248
−328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look into new implementation, and sub-components etc.
Add possibility to select parameter values and create subset of valid realization numbers for the intersection of selections
Component for visualizing and selecting realization numbers.
- Remove unused AddItemButton component - Add some svg icons for SmartNodeSelector
- Add compact visualization - Improve UX
Use circle divs row by row, as discussed in standup
Replace dynamic value with hard coded px values compact vs non-compact visualization
Start: Move filter state logic to parent component for "save all"/"discard all" functionality
Handle states for initial picker tags and smart node selector tags for correct visualization, when previous internal states are moved out to parent component
- When active: Hidden vs conditional rendering to preserve states - When not active, do not render filter details (will reset invalid smartNodeSelector tags)
…ns-fixes' into improve-realization-filter
- Fix minor issues with smartNodeSelector - To prevent complicated state handling of smartNodeSelector tags and parameter list, change functionality s.t. smartNodeSelector is used as a selector, and add button is included to add these active selections to the list of parameters below. - Fix hover info on unavailable reals in real number display
- Invalid tags - Already selected parameters
Create ranges based on sequence occurrence in valid realizations. To reduce number of ranges if an ensemble contains a lot of invalid realization numbers.
Move component from framework/components to framework/internal/components
jorgenherje
requested review from
rubenthoms,
HansKallekleiv,
Anders2303 and
anders-kiaer
and removed request for
rubenthoms
October 25, 2024 11:11
HansKallekleiv
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the RealizationFilter, by including a filter for each selected ensemble.
Upgrades to Realization Filter:
SmartNodeSelector:
onChange
datanodeIds
to be correct when using wildcardonChange
to trigger when clicking outside of componentsThe PR closes the following issues:
Closes: #690
Closes: #691
Closes: #321
Closes: #722