Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade realization filtering #741

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Upgrade realization filtering #741

wants to merge 37 commits into from
+3,248 −328

Conversation

jorgenherje
Copy link
Collaborator

@jorgenherje jorgenherje commented Oct 2, 2024 •
edited
Loading

This PR upgrades the RealizationFilter, by including a filter for each selected ensemble.

Upgrades to Realization Filter:

  • Realization filter drawer with one ensemble realization filter component for each selected ensemble
  • Can filter by parameter value, i.e. select continuous or discrete parameters (continuous and discrete), and select value range/discrete values to get realizations which matches these selections (intersection of all matches), i.e. &&-logic.
    • Slider to select range for continuous parameter values
    • Picker to select set of discrete values to match
  • Visualization of which realizations will be selected based on the current filter selections - display component.

SmartNodeSelector:

  • Provide valid state with the selected tags for onChange data
  • Fix selected nodeIds to be correct when using wildcard
  • Prevent onChange to trigger when clicking outside of components

The PR closes the following issues:

Closes: #690
Closes: #691
Closes: #321
Closes: #722

@jorgenherje
Prototyping backup - WIP
0c223cb 
Look into new implementation, and sub-components etc.
@jorgenherje
WIP
6339295
@jorgenherje
Parameter value filtering
038af15 
Add possibility to select parameter values and create subset of valid realization numbers for the intersection of selections
@jorgenherje jorgenherje added the enhancement New feature or request label Oct 2, 2024
@jorgenherje jorgenherje self-assigned this Oct 2, 2024
jorgenherje and others added 25 commits October 3, 2024 13:46
@jorgenherje
Make parameter selections map and selections readonly
0b718fc
@jorgenherje
Adjust gap for radio group
c90e0e6
@jorgenherje
Add realization number selector component and upgrade functionality
42b0470 
Component for visualizing and selecting realization numbers.
@jorgenherje
Improve categorization of discrete/numerical parameters
16b0167
@jorgenherje
Replace AddItemButton with SmartNodeSelector + minor fixes
68ffc27 
- Remove unused AddItemButton component
- Add some svg icons for SmartNodeSelector
@jorgenherje
Fix format error
7376d47
@jorgenherje
Merge branch 'main' into improve-realization-filter
0cd7a72
@jorgenherje
Merge branch 'main' into improve-realization-filter
578a945
@jorgenherje
BACKUP
0b0649a
@jorgenherje
Add compact visualization for selected realization number display
12012f1 
- Add compact visualization
- Improve UX
@jorgenherje
Adjust opacity based on active ensemble filters
dda1519
@jorgenherje
New suggestions for visualizations in realization number display
4fe595c
@jorgenherje
Use custom name or display name as Filter title
92b2944
@jorgenherje
Final compact/non-compact realization visualization
41c3527 
Use circle divs row by row, as discussed in standup
@jorgenherje
Fix issues with dynamic px values for tailwind class
627634b 
Replace dynamic value with hard coded px values compact vs non-compact visualization
@jorgenherje
Refactoring backup - WIP
3244c8d 
Start: Move filter state logic to parent component for "save all"/"discard all" functionality
@jorgenherje
Fix issues with realization picker tags and smart node selector tags
875971a 
Handle states for initial picker tags and smart node selector tags for correct visualization, when previous internal states are moved out to parent component
@jorgenherje
Replace conditional render with css style "hidden" when filter is active
aff578d 
- When active: Hidden vs conditional rendering to preserve states
- When not active, do not render filter details (will reset invalid smartNodeSelector tags)
@rubenthoms
wip
0133502
@rubenthoms
Adjustments to SmartNodeSelector
72e0b64
@jorgenherje
Backup - WIP
9718380
@jorgenherje
Merge remote-tracking branch 'rubenthoms/improve-realization-filter-s…
7fa18d7 
…ns-fixes' into improve-realization-filter
@jorgenherje
BACKUP
30e7d16
@jorgenherje
Adjust usage of SmartNodeSelector and minor fixes
b2771d8 
- Fix minor issues with smartNodeSelector
- To prevent complicated state handling of smartNodeSelector tags and parameter list, change functionality s.t. smartNodeSelector is used as a selector, and add button is included to add these active selections to the list of parameters below.
- Fix hover info on unavailable reals in real number display
@jorgenherje
Use React.useCallback in byRealizationNumberFilter
7988250
@jorgenherje jorgenherje marked this pull request as ready for review October 24, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansKallekleiv HansKallekleiv HansKallekleiv approved these changes

@Anders2303 Anders2303 Awaiting requested review from Anders2303

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

@rubenthoms rubenthoms Awaiting requested review from rubenthoms

Assignees

@jorgenherje jorgenherje

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@jorgenherje @HansKallekleiv @rubenthoms