More Policies #122
Open
More Policies #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
filmakarov
commented
Oct 3, 2024
•
filmakarov
commented
- Timeframe Policy
- UsageLimit Policy
- ValueLimit Policy
- GasLimit Policy
- Natspec everywhere
added 11 commits
October 3, 2024 13:29
kopy-kat
approved these changes
Oct 12, 2024
Co-authored-by: Konrad <[email protected]>
kopy-kat
reviewed
Oct 29, 2024
added 7 commits
November 1, 2024 13:30
…sessions into feat/moar-policies
kopy-kat
reviewed
Nov 1, 2024
feat: add ApprovalLimit policy, remove approvals from SpendingLimit
|
Need to fix conflicts coming from the fact SS was updated recently. I'll do that and re-requst reviews |
|
sounds good. make sure you rebase / merge with the latest changes from the stackup branch |
3 tasks
|
Hey @kopy-kat @highskore Please re-review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.