Merge pull request #1 from GCAE/work/nested-minify

Remove spaces when minifying new lines not in inline elements
erdomke · Oct 20, 2019 · cba73e5 · cba73e5
2 parents 07cc3a5 + d5e60cc
commit cba73e5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/BracketPipe.Tests/MinificationTests.cs b/src/BracketPipe.Tests/MinificationTests.cs
@@ -167,7 +167,6 @@ public void Minify_DontAlterWbr()
       Assert.Equal(input, Html.Minify(input));
     }
 
-
     [Fact]
     public void Minify_DontConcatenateScriptTags()
     {
@@ -188,5 +187,13 @@ public void Minify_MinifyScriptTags()
       settings.ScriptTypesToCompress.Clear();
       Assert.Equal(input, Html.Minify(input, settings));
     }
+
+    [Fact]
+    public void Minify_NoSpaceBetweenNestedElements()
+    {
+      Assert.Equal("<div>Foo</div><div></div>",
+  Html.Minify(@"<div>Foo</div>
+<div></div>"));
+    }
   }
 }
diff --git a/src/BracketPipe/Html.Minify.cs b/src/BracketPipe/Html.Minify.cs
@@ -149,7 +149,12 @@ public static IEnumerable<HtmlNode> Minify(this IEnumerable<HtmlNode> reader, Ht
             }
             else
             {
-              yield return new HtmlText(node.Position, " ");
+              // Inline elements can render spaces, otherwise spaces shouldn't be rendered between elements
+              if ((node.Type == HtmlTokenType.StartTag || node.Type == HtmlTokenType.EndTag)
+                && settings.InlineElements.Contains(node.Value))
+              {
+                yield return new HtmlText(node.Position, " ");
+              }
               if (settings.PreserveSurroundingSpaceTags.Contains(node.Value))
                 state = MinifyState.Compressed;
               else