-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ERP-2024] Added Past incident component #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change requested, good stuff!
Simple.args = { | ||
title: "Past Incidents", | ||
subTitle: "Showing all past incidents in the last 6 months", | ||
data: typedJsonData, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets put the data in the story as an arg, i.e. omit import jsonData from "../../../public/incidents.json"; This will keep the story static
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
} from "@chakra-ui/react"; | ||
|
||
interface Incident { | ||
datetime_reported: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported
Added Past incident component, stories & example incidents json data file