Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i1909 - attempting debug log rest api requests #1911

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pragmaxim
Copy link
Collaborator

@pragmaxim pragmaxim commented Nov 26, 2022

Closes #1909 ... Just note that there is a regression related to DEBUG logging #1676 (comment)

@kushti Is this OK ? Posting Bodies could just needlessly eat up disk space

12:22:26.564 DEBUG [tor.default-dispatcher-23] akka.actor.ActorSystemImpl - GET: http://localhost:9053/info

@pragmaxim pragmaxim marked this pull request as ready for review November 26, 2022 11:24
@@ -60,6 +60,7 @@ libraryDependencies ++= Seq(
"com.typesafe.akka" %% "akka-http" % akkaHttpVersion,
"com.typesafe.akka" %% "akka-parsing" % akkaHttpVersion,
"com.typesafe.akka" %% "akka-stream" % akkaVersion,
"com.typesafe.akka" %% "akka-slf4j" % akkaVersion,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new dependency needed for purposes of this PR ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this requires akka.event.slf4j.Slf4jLogger, the akka.event.LoggingAdapter does not log anything without it.

Copy link
Collaborator Author

@pragmaxim pragmaxim Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the configuration section I added should be always present when we are using SLF4J

Base automatically changed from v5.0.4 to master December 6, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants