Harden GitHub Actions workflows #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all GitHub Actions workflows following an analysis by zizmor [1]. In particular, this avoids persisting git credentials when the job does not need it, there's only one job that needs it which is the one that creates the git tag and updates the major version branch upon releases. Zizmor did have more concerns but these were not addressed, namely: - Overly permissive `permissions: read-all`: I think this is okay, the project is entirely open so I don't see a risk of an attacker reading anything. - Use of `pull_request_target: ~` in laberer.yml: as far as I'm aware this is the only way to have this setup work, and it does not run any untrusted code. -- 1. https://github.com/woodruffw/zizmor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #395, #401, #1114
Summary
Update all GitHub Actions workflows following an analysis by
zizmor. In particular, this avoids persisting git credentials when the job does not need it, there's only one job that needs it which is the one that creates the git tag and updates the major version branch upon releases.zizmordid have more concerns but these were not addressed, namely:permissions: read-all: I think this is okay, the project is entirely open so I don't see a risk of an attacker reading anything.pull_request_target: ~in laberer.yml: as far as I'm aware this is the only way to have this setup work, and it does not run any untrusted code.