[pull] main from gpuweb:main #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Better define anisotropic filtering * Update spec/index.bs Co-authored-by: Kai Ninomiya <[email protected]>
* Add logo to the spec and favicon * Update spec/index.bs Co-authored-by: Kai Ninomiya <[email protected]>
* Descriptions for remaining descriptor members * Update spec/index.bs Co-authored-by: Kai Ninomiya <[email protected]> --------- Co-authored-by: Kai Ninomiya <[email protected]>
* Attachment resolveTargets must also be pairwise disjoint * Apply Kai's suggestions from code review * Trying to better define the addressed texture subresources of a pass * Adjust verbiage slightly * Addressing more feedback from Kai --------- Co-authored-by: Kai Ninomiya <[email protected]>
…cript (#4554) * Take Attribute Values out of Enumerants and Specialize Syntax * Adjust according to review * Improve guidance for missing syntax directory * Fix duplicates from merge * Adjustments according to reviews * Subsection name tokens * Align subsections according to the feedback * Improve according to feedback * Adjust
* Both argument must be abstract to produce an abstract result, otherwise concrete types are used * Specifically `ldexp(1.0, 1i)` is valid * Add an explanatory note
The section for an attribute has the following structure:
<grammar>
<valid values><rules for the parameters>
<description> <must-rules>
<describe what it is>
That puts the high level information last.
Reorder the sections so they have this structure:
<grammar>
<description> <describe what it is>
<must-rules>
<parameters><rules for the parameters>
I think this reads better
Co-authored-by: Mehmet Oguz Derin <[email protected]>
Fixes #4561 * Add shader- and pipeline-creation errors to smoothstep if `low >= high` * A line break to improve rendering of the formula
Uses this function for all GPUObjectBase-derived types to ensure that the internal `[[device]]` and `[[label]]` are properly set on creation.
* Remove [[internal]] concept * Addressing feedback * Update spec/index.bs Co-authored-by: Kai Ninomiya <[email protected]>
* Indicate timeline for majority of algorithms * Addressing feedback * Define 'any timeline' * Apply Kai's suggestions from code review * More feedback * Apply more Kai suggestions from code review --------- Co-authored-by: Kai Ninomiya <[email protected]>
Fixes #4623 * Add bit reinterpretation built-in functions to list of flushable functions
…s valid or not. (#4608)
Add the restriction that only a single aspect (stencil-only or depth-only) may be used specified per texture in a given draw.
* Add missing limits to the correspondence doc * Apply Kai's suggestions from code review --------- Co-authored-by: Kai Ninomiya <[email protected]>
…4641) * Add coordinate system diagrams and fix NDC to framebuffer equation * Apply Kai's suggestions from code review * Address more feedback * Made the diagrams responsive to light/dark mode * Apply more of Kai's suggestions from code review --------- Co-authored-by: Kai Ninomiya <[email protected]>
sample_mask and sample_index usage should genearte an error at shader module creation time, not pipleine creation time.
* Compat: disallow @interpolate(flat, first)
* Add a better definition for 'texture' * Addressing Corentin's feedback * Apply Kai's suggestion --------- Co-authored-by: Kai Ninomiya <[email protected]>
* wgsl: bool has size and alignment of 4 bytes Fixed: #4972 * Explain why bool is 4 bytes, in a note
Also add a note saying multiple non-conflicting global diagnostic filters are permitted. Issue: #4976
* Adding clearer notes and examples for dynamic offset ordering * Apply Kai's suggestions from code review * Add a static+dynamic offset example --------- Co-authored-by: Kai Ninomiya <[email protected]>
* WIP: texture buffers * Remove memory model modifications These have landed in the main spec. * Address some review comments * Make it a core feature * Rename to "texel buffer" * Remove formats that are not widely supported * Update open questions with decision on core vs extension * Add restriction for vertex shaders
* wgsl: @align(n) must divide required-align-of, for all structs Reverses: #3756 - The previous phrasing was a note that was "implied" by other rules. It wasn't actually perfectly implied. - Avoids a silly and confusing case with the first element of a struct. - Brings the spec more in line with Naga and WebKit. - More clearly applies the rule for *all* structs, no matter if it is actually instantiated by a variable. * Add missing word Co-authored-by: alan-baker <[email protected]> --------- Co-authored-by: alan-baker <[email protected]>
* Switch "validating GPUVertexState" to algorithm style * Fix attribute validation
I believe these examples are left over from before WGSL had `for` loops. Now that WGSL has for loops these examples showing a `for` loop expressed with `loop` can directly reference `for` in WGSL. Fixed: #4996
Introduce float16-renderable and float32-renderable as optional features in Compatibility mode, and required in Core.
Add new limits for storage buffers and textures in the fragment stage.
* Add attributes * Normalize line endings * Trim trailing blankspaces * Make endings consistent
Now that GPUAdapter.featureLevel has landed in the core spec, remove the GPUAdapter.compatibilityMode IDL change from the proposal. Explain that setting GPUAdapter.featureLevel to "compatibility" enables Compatibility Mode validation. Change the GPUAdapter.isCompatibilityMode boolean to a "featureLevel" DOMString.
* texel buffer proposal: Update from review - Clarify Metal limits are in units of pixels - Add TODO to get info for pre-Apple silicon Metal GPUs - Add @teoxoy's question about uniform texel buffer as an open question Followup to #4912 * Update per review Resolve the 'uniform texel buffer' question: read-only views map to uniorm texel buffers. Add the question about needing another create-view method for these.
`Status: LD` is "Living Document", which makes sense but has broken CSS if used with `Group: webgpu`. If not used with `Group: webgpu` then the license is CC0 (Public Domain) which is probably fine but not really appropriate. `Status: UD` is "Unofficial Proposal Draft", which is not really what I would call this document, but it renders correctly :) Any other status causes an error message saying something like: "You used Status NOTE, but your Group (WEBGPU) is limited to the statuses CG-DRAFT, CG-FINAL, or UD." (Probably LD isn't supposed to be used either and that's why it's broken.) Documentation: https://speced.github.io/bikeshed/#metadata
New spec drafts need to be published as "Candidate Recommendation Drafts". This status requires a deadline date to be specified. That deadline could be set as a `W3C_BUILD_OVERRIDE` parameter in the workflow, but then it's inherent to the specs, so it seems good to have it defined in the source directly. (That information is not useful for the Editor's Draft in theory, but also needed in practice since Bikeshed replaces all macro texts in the boilerplate before it drops the bits that aren't needed). The update also adds a link to the test suite in WebGPU and renames "Tests" into "Test Suite" in WGSL (usual name across specs).
* API
* new feature: subgroups
* new properties for adapter info:
* subgroupMinSize
* subgroupMaxSize
* WGSL
* new enable: subgroups
* new built-in values
* subgroup_invocation_id
* subgroup_size
* subgroup and quad built-in functions
* new uniformity diagnostic subgroup_uniformity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )