BREAKING CHANGE: add task ID segment to local artifact path #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
task-id-path-segment
branch
from
b43cd7b to
00b581d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 1.0.2/#21, I accidentally swapped the index of "identical" tasks with a run ID, but removed a distinguishing path segment between different tasks. The result is that
treeherder-dlinvocations would overwrite artifacts when there was more than a single task based on the same job. Oops! 😳I don't think a counter-as-an-ID is as useful as the task ID itself. This will significantly lengthen the output path for artifacts, but I think it's the best option.
We cannot avoid a breaking change here; #21 should have been a breaking change, in retrospect, if we had done it correctly.