Easier to change LEDs #252
Conversation
|
I cant find the original discussion but I believe we implemented directly setting the LEDs like that as we could do it in fewer cycles which (IIRC) did provide a noticeable speed bump. Is there any way you could run a side by side comparison of your change and the original way to ensure there's not a regression in speed? |
|
I’m still waiting for some parts to build up my BlueSCSI, so I can’t do any benchmarking right now, but I’ll take another look and see if I can use some constants and bitshifting and bitwise operators to accomplish this like was being done before |
|
Alright, tried again, this time using all macros and defines so that everything gets sorts out at compile time, and this should generate the same code as before. Not quite as nice to only have to set a single define to change the pin, but not horrendous either, and a little less opaque to anyone else trying to read or change this code |
- For building for boards with different LEDs and configurations - Define mode for LED - Update GPIO macros for port C - Use macros to generate bits for registers
|
Rebased this, swapped the pin initialization back to the same order, and then confirmed that this builds a byte-for-byte binary against main |
I've got a BluePill with slightly different pins in use for the internal LED and PA0, and in trying to change them, I wanted an easier way to do so in the defines.
Switched from setting the GPIO register directly to using gpio_write, which does add 104 bytes or so