-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template review: code templates should match the default scaffolding #29
Conversation
so.. what would make it easier... creating a sample project that can run blog | http://Hex.LosTechies.com On Wed, Dec 5, 2012 at 4:55 AM, Marijn van der Zee <[email protected]
|
Sounds good. Such a project could also serve to "communicate" the goals and concerns of the project too (see #27). E.g.:
|
I created a separate nuget for the templates.. as far as making it easier to back port changes.. this is the process you can use modify the templates your using.. you can also automate this process like i did in the test\endtoend\tests.ps1 file.. I run that from a nuget console in a separate instance of vs and I can easily try out the packages that the build.ps1 creates in a new solution. |
That would work. I'll give have a look at it somewhere in the next couple of weeks. Nice work! |
should i merge this or are you just reviewing it? |
I'd like to get all tasks checked before you merge. I'll reopen when done. Code templates are useful, but only if they match the default scaffolding. And don't produce annoying compile errors, that's a big turn-off for me ATM. |
I'm not sure which components out expect a `Edit.tt`, so I figured it would be best to make sure we ship one.
the compile errors in temp files should be gone
@erichexter @MisterJames please consider accepting this pull, or add some feedback for me, so I can approve it. It's kind of blocking further improvements; e.g.#79 #89. |
Template review: code templates should match the default scaffolding
I'll use this pull request to port back some changes I made to the templates.
Notes
Depends on pull #65 (confirm delete)
Tasks
ControllerWithContext.cs.tt
bug, see ControllerWithContext.tt template bug #57 only namespace addition needed 5075381_views\shared
Create.tt