Added ActiveRecord extension type to support findBySql method usages #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erickskrauch hello, could you please take a look at this? |
Hello. Yes, I have already seen this PR. Unfortunately, it requires time to read and understand what you have submitted. And at the moment I don't have it :( I'll take a look at this PR later. Until then you can just use your fork. Take a look at this article to learn how to. |
|
Okay, got it
|
erickskrauch
requested changes
May 23, 2024
erickskrauch
approved these changes
May 28, 2024
|
@iVovolk, thank you very much for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just in a couple of days long relationship with phpstan, trying to integrate it into a legacy project i'm currently working on.
While switching options i found out that your extension suits it the best. Though i found some cases where it lacks some features.
In this PR i'm proposing an update to add support for
ActiveRecord::findBySql()which i use in my project. And even though i have not tested it i belive that this update also allows easy implemetation ofActiveRecord::findByCondition()support.