Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.3 compatibility #6

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Add PHP 8.3 compatibility #6

merged 2 commits into from
Nov 1, 2024

Conversation

paxal
Copy link
Contributor

@paxal paxal commented Oct 2, 2024

Hello, this is the PR for php8.3, waiting for tests to pass 🤞

@paxal
Copy link
Contributor Author

paxal commented Oct 2, 2024

Sounds like we hit https://bugs.php.net/bug.php?id=52335

fseek() to an offset that doesn't exist results in NULL bytes added.

@ericnorris ericnorris merged commit d1d36a8 into ericnorris:main Nov 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants