Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txpool: Don't propagate transactions with duplicate authorizations #13137

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

txpool: Don't propagate transactions with duplicate authorizations #13137

wants to merge 2 commits into from

Conversation

shohamc1
Copy link
Member

Fixes #11763

@yperbasis yperbasis added the pectra The Prague/Electra protocol upgrade label Dec 17, 2024
AskAlexSharov
AskAlexSharov reviewed Dec 19, 2024
View reviewed changes
core/types/authorization.go Outdated
@@ -36,8 +36,12 @@ func (ath *Authorization) copy() *Authorization {
}

func (ath *Authorization) RecoverSigner(data *bytes.Buffer, b []byte) (*libcommon.Address, error) {
if ath.Nonce == 1<<64-1 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

math.MaxUint64

@dvovk
Copy link
Member

dvovk commented Dec 19, 2024

It feels like the addTxnsOnNewBlock func require check for SetCodeTxnType as it basically do the same checks as addTxns but I'm not 100% sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AskAlexSharov AskAlexSharov AskAlexSharov left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pectra The Prague/Electra protocol upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework txpool for EIP-7702
4 participants
@shohamc1 @dvovk @AskAlexSharov @yperbasis