[DO-NOT-MERGE] txpool: streamline initialisation #13202
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR IS IN DRAFT (but want to run CI)
Attempt to simplify how we initialise and run the
TxPool
.Observations:
Fetch
,Sender
,PoolDB
,newTxs chan txpool.Announcements
. I see these all as internal components of theTxPool
thatbackend.go
and other initialisers should not care about. In reality, the only thingsbackend.go
cares about are theTxPool
and theTxPoolGrpcServer
.This PR addresses the above by:
Run(ctx)
pattern that we are using in Astrid and Shutter where each runnable component is responsible for starting its own background goroutines, loops, listeners, etc. and also is responsible for shutting them all down by being ctx-aware (ie when ctx is cancelled all sub components gets disposed of/shutdown)