Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caplin: simplified cache-query #13247

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Caplin: simplified cache-query #13247

merged 4 commits into from
Dec 27, 2024

Conversation

Giulio2002
Copy link
Contributor

This PR should simplify the cache system during reorgs by removing caches which should not be bottlenecks anymore

@Giulio2002 Giulio2002 marked this pull request as draft December 26, 2024 17:47
@Giulio2002
Copy link
Contributor Author

close #13204

@Giulio2002
Copy link
Contributor Author

close #13217

@Giulio2002
Copy link
Contributor Author

Giulio2002 commented Dec 26, 2024

misplaced a lock. now it will also close #13229 and #13224

@errge
Copy link
Contributor

errge commented Dec 26, 2024

hey @Giulio2002

Thank you for working on this, I'd be happy to test drive this.

Can you please ping me when/if you can guarantee the following about the PR:

  • no change of the on-disk format (so if something goes wrong, I can just rollback to official alpha7 without resync)
  • PR is ready for testing.

If we can meet these conditions, I can put this on my machine and test it with the same workflow that causes the crashes now.

@Giulio2002
Copy link
Contributor Author

no change in disk format. ready for testing. the only thing it can happen is that the you get an invalid state root somewhere down the line.

@errge
Copy link
Contributor

errge commented Dec 26, 2024

no change in disk format. ready for testing. the only thing it can happen is that the you get an invalid state root somewhere down the line.

Sorry, I'm not familiar with the internals enough to parse. If this happens, that causes a crash and I'm fine? Or will I have to somehow rollback my disk state to be able to rollback to alpha7? So would this state root be saved somewhere inhibiting recovery in case of failure?

@Giulio2002
Copy link
Contributor Author

Giulio2002 commented Dec 26, 2024

if that happens, you can just restart and nothing will be broken

@errge
Copy link
Contributor

errge commented Dec 26, 2024

Thank you, much appreciated your friendly handling of the issue, I will do the build and report back after a day or two

@errge
Copy link
Contributor

errge commented Dec 27, 2024

The fix works, crash was happening every 1-2 hours under my usage, now didn't crash for 6 straight hours.

Thank you!

@Giulio2002 Giulio2002 marked this pull request as ready for review December 27, 2024 11:58
@Giulio2002 Giulio2002 merged commit bd519f0 into main Dec 27, 2024
24 checks passed
@Giulio2002 Giulio2002 deleted the cache-simplify branch December 27, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants