-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caplin: simplified cache-query #13247
Conversation
close #13204 |
close #13217 |
hey @Giulio2002 Thank you for working on this, I'd be happy to test drive this. Can you please ping me when/if you can guarantee the following about the PR:
If we can meet these conditions, I can put this on my machine and test it with the same workflow that causes the crashes now. |
no change in disk format. ready for testing. the only thing it can happen is that the you get an invalid state root somewhere down the line. |
Sorry, I'm not familiar with the internals enough to parse. If this happens, that causes a crash and I'm fine? Or will I have to somehow rollback my disk state to be able to rollback to alpha7? So would this state root be saved somewhere inhibiting recovery in case of failure? |
if that happens, you can just restart and nothing will be broken |
Thank you, much appreciated your friendly handling of the issue, I will do the build and report back after a day or two |
The fix works, crash was happening every 1-2 hours under my usage, now didn't crash for 6 straight hours. Thank you! |
This PR should simplify the cache system during reorgs by removing caches which should not be bottlenecks anymore