Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/test/ethereum: add support for EEST #2433

Closed
wants to merge 1 commit into from
Closed

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 21, 2024

Add support for Ethereum Execution Spec Tests (EEST) fixtures (archives of generated JSON tests). In EEST fixtures blockchain tests are placed in blockchain_tests subdirectory so register it for the blockchain test runner.

Usage is:

cmd/test/ethereum --tests path/to/fixtures

Example EEST release:
https://github.com/ethereum/execution-spec-tests/releases/tag/v3.0.0

Add support for Ethereum Execution Spec Tests (EEST) fixtures
(archives of generated JSON tests). In EEST fixtures blockchain tests
are placed in `blockchain_tests` subdirectory so register it for the
blockchain test runner.

Usage is:

    cmd/test/ethereum --tests path/to/fixtures

Example EEST release:
https://github.com/ethereum/execution-spec-tests/releases/tag/v3.0.0
@chfast
Copy link
Member Author

chfast commented Oct 21, 2024

There is one test failing in EEST: https://github.com/ethereum/execution-spec-tests/blob/main/tests/constantinople/eip1014_create2/test_recreate.py. Someone should take a look.

Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EEST are already run in CI. From "Execution spec tests" in .circleci/config.yml:

cmd/test/ethereum --tests $HOME/project/third_party/execution-spec-tests

@canepat
Copy link
Member

canepat commented Nov 27, 2024

I'm closing this because EEST are already supported in cmd/test/ethereum utility.

The failing test tracked by #2443 is fixed by #2541.

@canepat canepat closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants