-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: upgrade to Conan 2 (#2318) #2607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
added
the
maintenance
Some maintenance work (fix, refactor, rename, test...)
label
Dec 16, 2024
battlmonstr
force-pushed
the
ci/conan2
branch
2 times, most recently
from
December 17, 2024 14:43
fa9cf51
to
ec989b5
Compare
battlmonstr
force-pushed
the
ci/conan2
branch
3 times, most recently
from
December 17, 2024 21:16
f5c41ee
to
948848f
Compare
battlmonstr
force-pushed
the
ci/conan2
branch
from
December 17, 2024 22:32
dec7139
to
e4eddea
Compare
battlmonstr
force-pushed
the
ci/conan2
branch
from
December 18, 2024 09:58
e4eddea
to
6ee6a82
Compare
battlmonstr
force-pushed
the
ci/conan2
branch
from
December 20, 2024 09:29
6ee6a82
to
baa5e31
Compare
battlmonstr
force-pushed
the
ci/conan2
branch
from
December 26, 2024 09:23
baa5e31
to
33a04d6
Compare
battlmonstr
force-pushed
the
ci/conan2
branch
from
December 26, 2024 12:53
38965b8
to
51f164f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2607 +/- ##
=======================================
Coverage 50.87% 50.88%
=======================================
Files 775 775
Lines 52284 52284
Branches 8112 8112
=======================================
+ Hits 26601 26605 +4
+ Misses 23358 23356 -2
+ Partials 2325 2323 -2 ☔ View full report in Codecov by Sentry. |
Great work! |
canepat
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extras
performance
"light" workflow jobs build time of conan (cmake configuration command):
conan 2 has no clang binaries for Linux, so the first build on clang has to build everything from source. That takes 10 min longer compared to conan 1 where we build only 2-3 libs from source. It is cached and then the build time is about equal.