Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: upgrade to Conan 2 (#2318) #2607

Merged
merged 2 commits into from
Dec 31, 2024
Merged

cmake: upgrade to Conan 2 (#2318) #2607

merged 2 commits into from
Dec 31, 2024

Conversation

battlmonstr
Copy link
Contributor

extras

  • refactor compiler_install.sh
  • reduce verbosity of cmake configuration output

performance

"light" workflow jobs build time of conan (cmake configuration command):

gcc (linux-gcc-12-release) - no conan cache
- conan 1 - 2,6 min
- conan 2 - 2,5 min
clang (linux-clang-16-release) - no conan cache
- conan 1 - 3 min
- conan 2 - 13 min

gcc (linux-gcc-12-release) - with conan cache
- conan 1 - 0,3 min
- conan 2 - 0,23 min
clang (linux-clang-16-release) - with conan cache
- conan 1 - 0,25  min
- conan 2 - 0,22  min

conan 2 has no clang binaries for Linux, so the first build on clang has to build everything from source. That takes 10 min longer compared to conan 1 where we build only 2-3 libs from source. It is cached and then the build time is about equal.

@battlmonstr battlmonstr added the maintenance Some maintenance work (fix, refactor, rename, test...) label Dec 16, 2024
@battlmonstr battlmonstr marked this pull request as ready for review December 16, 2024 13:45
@battlmonstr battlmonstr requested a review from canepat December 16, 2024 13:45
@battlmonstr battlmonstr marked this pull request as draft December 16, 2024 13:45
@battlmonstr battlmonstr force-pushed the ci/conan2 branch 2 times, most recently from fa9cf51 to ec989b5 Compare December 17, 2024 14:43
@battlmonstr battlmonstr force-pushed the ci/conan2 branch 3 times, most recently from f5c41ee to 948848f Compare December 17, 2024 21:16
@battlmonstr battlmonstr marked this pull request as ready for review December 17, 2024 22:32
@battlmonstr battlmonstr disabled auto-merge December 18, 2024 09:53
@battlmonstr battlmonstr marked this pull request as draft December 18, 2024 09:53
@battlmonstr battlmonstr marked this pull request as ready for review December 18, 2024 09:58
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.88%. Comparing base (7923eb4) to head (51f164f).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2607   +/-   ##
=======================================
  Coverage   50.87%   50.88%           
=======================================
  Files         775      775           
  Lines       52284    52284           
  Branches     8112     8112           
=======================================
+ Hits        26601    26605    +4     
+ Misses      23358    23356    -2     
+ Partials     2325     2323    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canepat
Copy link
Member

canepat commented Dec 31, 2024

Great work!

@battlmonstr battlmonstr merged commit aa9f450 into master Dec 31, 2024
16 checks passed
@battlmonstr battlmonstr deleted the ci/conan2 branch December 31, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants