snapshots: queries refactoring #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
battlmonstr
commented
Dec 26, 2024
•
battlmonstr
commented
- switch names: Query -> SegmentQuery, MultiQuery -> Query
- simplify TransactionBlockNumByTxnHashMultiQuery to follow a "multi-bundle query" pattern
- SnapshotRepository read-only interface for queries
- multi-bundle queries: FindMapQuery, FindByTimestampMapQuery
- access_layer DataModel refactoring to use multi-bundle queries
- refactor RecSplitIndex ordinal lookup: improve type safety and naming
- non-null EliasFanoDecoder value
- KVSegmentValuesReader
battlmonstr
added
snapshots
battlmonstr
force-pushed
the
pr/sn_queries
branch
2 times, most recently
from
290e814 to
d4644d0
Compare
battlmonstr
force-pushed
the
pr/sn_queries
branch
3 times, most recently
from
9515f59 to
081a489
Compare
battlmonstr
force-pushed
the
pr/sn_queries
branch
from
081a489 to
baddead
Compare
canepat
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.