Skip to content

Commit

Permalink
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES_ERROR
Browse files Browse the repository at this point in the history
===== CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES_ERROR =====

This warning is an Xcode 12 recommendation (technically, the warning
is not YES_ERROR, but setting error will ensure that future changes
won't regress consumers of OCMock that also set this setting).

This setting will help assure modules importing OCMock that it's
closure of headers is all modular, and will allow projects also
setting this setting to build against OCMock without error.

Inspection & testingreveals it is also available already for Xcode11.

Changes to .h are the result of
- setting CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES_ERROR
- building
- applying the fix recommended by Xcode
  • Loading branch information
Kirk Beitz committed Aug 29, 2020
1 parent 3dde0e4 commit 843cfd5
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 16 deletions.
2 changes: 2 additions & 0 deletions Source/OCMock.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1713,6 +1713,7 @@
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES_ERROR;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION = YES;
Expand Down Expand Up @@ -1770,6 +1771,7 @@
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES_ERROR;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION = YES;
Expand Down
2 changes: 1 addition & 1 deletion Source/OCMock/OCMLocation.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import <Foundation/Foundation.h>
#import "OCMFunctions.h"
#import <OCMock/OCMFunctions.h>

@interface OCMLocation : NSObject
{
Expand Down
5 changes: 3 additions & 2 deletions Source/OCMock/OCMStubRecorder.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@
* under the License.
*/

#import "OCMRecorder.h"
#import "OCMFunctions.h"
#import <OCMock/OCMRecorder.h>
#import <OCMock/OCMFunctions.h>

#import <objc/runtime.h>

@interface OCMStubRecorder : OCMRecorder
Expand Down
2 changes: 1 addition & 1 deletion Source/OCMock/OCMVerifier.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* under the License.
*/

#import "OCMRecorder.h"
#import <OCMock/OCMRecorder.h>

@class OCMLocation;
@class OCMQuantifier;
Expand Down
24 changes: 12 additions & 12 deletions Source/OCMock/OCMock.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
* under the License.
*/

#import "OCMockObject.h"
#import "OCMockMacros.h"
#import "OCMRecorder.h"
#import "OCMVerifier.h"
#import "OCMStubRecorder.h"
#import "OCMConstraint.h"
#import "OCMArg.h"
#import "OCMLocation.h"
#import "OCMQuantifier.h"
#import "OCMMacroState.h"
#import "NSNotificationCenter+OCMAdditions.h"
#import "OCMFunctions.h"
#import <OCMock/OCMockObject.h>
#import <OCMock/OCMockMacros.h>
#import <OCMock/OCMRecorder.h>
#import <OCMock/OCMVerifier.h>
#import <OCMock/OCMStubRecorder.h>
#import <OCMock/OCMConstraint.h>
#import <OCMock/OCMArg.h>
#import <OCMock/OCMLocation.h>
#import <OCMock/OCMQuantifier.h>
#import <OCMock/OCMMacroState.h>
#import <OCMock/NSNotificationCenter+OCMAdditions.h>
#import <OCMock/OCMFunctions.h>

0 comments on commit 843cfd5

Please sign in to comment.