Enable lager to use the OTP logger's event pipeline #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some things we need to do:
|
jadeallenx
reviewed
Mar 2, 2020
src/lager.erl
Outdated
| Formatter = proplists:get_value(formatter, Config, lager_default_formatter), | ||
| FormatterConfig = proplists:get_value(formatter_config, Config, []), | ||
| %% XXX I don't think disk_log is suitable as it is, we should provide a logger compatible version of | ||
| %% lager's file_backend and try to patch disk_log upstream |
| false -> | ||
| %% set up the config, is safe even during relups | ||
| lager_config:new(), | ||
| %% TODO: |
There was a problem hiding this comment.
Nitpick: probably should delete or update this comment
| do_format(Level, Msg, Metadata, Config) -> | ||
| FormatModule = maps:get(formatter, Config, lager_default_formatter), | ||
| Timestamp = maps:get(time, Metadata), | ||
| MegaSecs = Timestamp div 1000000000000, |
There was a problem hiding this comment.
Make these numbers macros to improve readability and maintenance sanity, please.
hauleth
reviewed
Mar 2, 2020
| {application, Name} = lists:keyfind(application, 1, Report), | ||
| Formatted = error_logger_lager_h:format_reason(Reason), | ||
| {"Application ~w exited with reason: ~s", [Name, Formatted]} | ||
| end. |
There was a problem hiding this comment.
This will fail on custom reports, ex.:
?LOG_INFO(#{http_reponse => 200, request_duration => Duration})| @@ -689,6 +690,64 @@ rotate_handler(Handler) -> | |||
| rotate_handler(Handler, Sink) -> | |||
| gen_event:call(Sink, Handler, rotate, ?ROTATE_TIMEOUT). | |||
|
|
|||
| generate_logger_config() -> | |||
| Handlers = application:get_env(lager, handlers, lager_app:default_handlers()), | |||
| {Level, NewHandlers} = generate_logger_handlers(Handlers, {notice, []}), | |||
There was a problem hiding this comment.
Maybe instead of "translating" Lager handlers (which will not support custom handlers anyway) to logger handlers, add new handler that will forward all messages from the logger to lager's gen_event as a compatibility layer.
| {lager_logger_formatter, #{report_cb => fun lager_logger_formatter:report_cb/1, | ||
| formatter => Formatter, | ||
| formatter_config => FormatterConfig}}}}, | ||
| NewLevel = case lager_util:level_to_num(Level) > lager_util:level_to_num(CurrentLevel) of |
There was a problem hiding this comment.
Instead of that you can use logger:compare_levels/2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should really get this finished so let's try to figure out what's missing.