Add config to enable on type formatting, defaulting to false

apps/els_core/src/els_config.erl

@@ -106,6 +106,7 @@ do_initialize(RootUri, Capabilities, {ConfigPath, Config}) ->
   ok = add_code_paths(CodePathExtraDirs, RootPath),
   ElvisConfigPath = maps:get("elvis_config_path", Config, undefined),
   BSPEnabled = maps:get("bsp_enabled", Config, false),
+  FormatOnTypeEnabled = maps:get("format_on_type", Config, false),
 
   %% Passed by the LSP client
   ok = set(root_uri       , RootUri),
@@ -118,6 +119,7 @@ do_initialize(RootUri, Capabilities, {ConfigPath, Config}) ->
   ok = set(macros         , Macros),
   ok = set(plt_path       , DialyzerPltPath),
   ok = set(code_reload    , CodeReload),
+  ok = set(format_on_type , FormatOnTypeEnabled),
   ?LOG_INFO("Config=~p", [Config]),
   ok = set(runtime, maps:merge( els_config_runtime:default_config()
                               , Runtime)),

apps/els_lsp/src/els_formatting_provider.erl

@@ -45,9 +45,10 @@ is_enabled_range() ->
 %%       make sense.
 -spec is_enabled_on_type() -> document_ontypeformatting_options().
 is_enabled_on_type() ->
-  #{ firstTriggerCharacter => <<".">>
-   , moreTriggerCharacter => []
-   }.
+  case els_config:get(format_on_type) of
+    true -> #{firstTriggerCharacter => <<".">>, moreTriggerCharacter => []};
+    false -> false
+  end.
 
 -spec handle_request(any(), state()) -> {any(), state()}.
 handle_request({document_formatting, Params}, State) ->
@@ -159,7 +160,7 @@ ontypeformat_document(_Uri, Document, Line, Col, <<".">>, _Options) ->
                {ok, Bin} = file:read_file(TmpFile),
                Bin
             end,
-          %% rebar3_formatter adds a newline, since we terminate on.
+          %% rebar3_formatter adds a newline, since we terminate on .
           %% We want to leave the cursor at the current char rather
           %% than jumping to a newline
           NewText =