Merge pull request #1071 from erlang-ls/1070-fix-distribution-when-no…

…-cookie-is-specified

[#1070] Only set the cookie if the provided one is a valid one

apps/els_core/src/els_distribution_server.erl

@@ -63,13 +63,17 @@ start_distribution(Name) ->
   NameType = els_config_runtime:get_name_type(),
   start_distribution(Name, RemoteNode, Cookie, NameType).
 
--spec start_distribution(atom(), atom(), atom(),
-                         shortnames | longnames) -> any().
+-spec start_distribution(atom(), atom(), atom(), shortnames | longnames) -> ok.
 start_distribution(Name, RemoteNode, Cookie, NameType) ->
   ?LOG_INFO("Enable distribution [name=~p]", [Name]),
   case net_kernel:start([Name, NameType]) of
     {ok, _Pid} ->
-      erlang:set_cookie(RemoteNode, Cookie),
+      case Cookie of
+        nocookie ->
+          ok;
+        CustomCookie ->
+          erlang:set_cookie(RemoteNode, CustomCookie)
+      end,
       ?LOG_INFO("Distribution enabled [name=~p]", [Name]);
     {error, {already_started, _Pid}} ->
       ?LOG_INFO("Distribution already enabled [name=~p]", [Name]);