Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive in maybe expression #1531

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix false positive in maybe expression #1531

wants to merge 3 commits into from

Conversation

MarkoMin
Copy link
Contributor

Description

Here is just the test case that confirms it. Hope I'd manage to get some time to write a solution.

Fixes #1527

@MarkoMin
Copy link
Contributor Author

Just discovered that not only else variables are false positives, but variables in maybe body are false negatives. I've updated an existing test to cover that.

@MarkoMin MarkoMin mentioned this pull request Sep 13, 2024
Open
@MarkoMin
Copy link
Contributor Author

MarkoMin commented Sep 13, 2024 •
edited
Loading

Turns out we'll have to wait for new OTP release to fix it. When I run this with OTP patch I submitted, the added testcase passes.

P.S: How should we this in lower OTP versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maybe/else pattern erroneously triggering 'bound variable in pattern' error
1 participant
@MarkoMin