Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test unusual rebar3 corner case where release will fail #2539

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ebengt
Copy link

@ebengt ebengt commented Apr 17, 2021

Test a unusual rebar3 corner case where an Elixir package, built with mix plugin, is released.
If done directly, without previous build, the release will fail.
Repeat the release, or compile/test before the first release, and the release is successful.

First build rebar3 escript used by this test suite.
rebar3 escriptize

Then run the test
rebar3 ct --suite mixplugin_SUITE

Test a unusual rebar3 corner case where an Elixir package, built with mix plugin, is released.
If done directly, without previous build, the release will fail.
Repeat the release, or compile/test before the first release, and the release is successful.

First build rebar3 escript used by this test suite.
 rebar3 escriptize
@ferd
Copy link
Collaborator

ferd commented Apr 17, 2021

Thanks. I'll consider this as a bug report with a reproducible case more than an actual test suite.

I'm not too sure where the final test should belong for this when we figure out a fix since our own test suites avoid depending on the behaviour of third-party plugins or requiring a whole different programming language, but it should help figure out issues and fixes.

@ferd ferd added the bug label Apr 17, 2021
@ebengt
Copy link
Author

ebengt commented Apr 18, 2021

Thank you. I tried, and failed, to create a real test case (without plugin, etc).

This is a bandaid, covering that this one time vsn is a binary,
instead of a list. One real solution would be to find out why vsn
is binary, and change it there.
@ebengt
Copy link
Author

ebengt commented Apr 18, 2021

The work around makes both mixplugin tests pass on my laptop.

@ferd
Copy link
Collaborator

ferd commented Apr 18, 2021

Were you on the latest master branch? There was already a fix in the line for some binary-looking versions I believe.

@ebengt
Copy link
Author

ebengt commented Apr 18, 2021

Yes, the master of 17:th April, as far as I know.

@ebengt
Copy link
Author

ebengt commented Apr 18, 2021

Please let me know when reabr3, the escript, will be updated with these ''binary-looking versions''. I can get it then and test.

@ferd
Copy link
Collaborator

ferd commented Apr 19, 2021

It should already have them as of yesterday's release.

@ebengt
Copy link
Author

ebengt commented Apr 20, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants