Fix: Update prometheus-client-mmap dependency version and add Ruby 3.3 to the test matrix #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@errm can you review this one? I guess it flew under the radar during the holidays |
errm
approved these changes
Jan 24, 2024
|
It looks like v1.1 of prometheus-client-mmap bundles a precompiled extension anyway - so that might be okay IMO. |
|
ah, I missed this when I was updating. I could try upgrade it further if you prefer |
|
I am guessing it came after you pushed this change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy Holidays 🎄 🎉
Fixes #49
Edit: I bumped to v1.x but found out that since 1.0, it requires Rust, so I downgraded to 0.28, which is known to work with Ruby 3.3. I think that the update to v1 and Rust requirement is your call to make