Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pitchfork Memory Stats #68

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Add Pitchfork Memory Stats #68

merged 7 commits into from
Sep 20, 2024

Conversation

robertomiranda
Copy link
Collaborator

@robertomiranda robertomiranda commented Aug 23, 2024

Introduce Pitchfork Memory Stats. This PR integrates memory statistics collection into the Pitchfork middleware introduced in #66.

  • pitchfork_mem_rss: Resident Set Size of the Pitchfork process, representing the total memory used by the process.
  • pitchfork_shared_mem: Shared memory of the Pitchfork process, indicating memory shared between multiple processes.

These metrics provide more detailed insights into memory-sharing efficiency.

Additionally, the PR introduces a pitchfork_stats_enabled flag to toggle Pitchfork metrics collection on or off.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d663938) to head (c4d5adc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        38    +1     
  Lines          833       854   +21     
=========================================
+ Hits           833       854   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertomiranda robertomiranda marked this pull request as ready for review August 23, 2024 09:20
@robertomiranda robertomiranda changed the title Add Pitfork Memory Stats Add Pitchfork Memory Stats Sep 5, 2024
Copy link
Owner

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Nice use of rack after reply :)

@robertomiranda robertomiranda merged commit 6442f72 into master Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants