Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: reset footnote count after each «text» call #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix: reset footnote count after each «text» call #109

wants to merge 1 commit into from

Conversation

rubenrubiob
Copy link

This addresses #97 : if you are parsing multiple text within a loop, the footnote count is never reset, so it keeps adding values.

For the tests, I added a new method for testing two calls to the sample text containing the footnotes and checking that after both calls the content is the same. I do not like it that much, because it leaves the code for the test a little bit dirty, as it uses the ParsedownTest tests. Another solution would be to create a new test file or, even cleaner, to perform two calls in ParsedownTest. I would change them if it is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant