Fixes Issue #44 #58

acmitch · 2015-04-07T15:22:46Z

Recreated this pull request to clean up the chatter and many commits.

This fixes issue #44 by chaning this:

# remove <!DOCTYPE 
$doc->removeChild($doc->doctype);           

# remove <html><body></body></html> 
$doc->replaceChild($doc->firstChild->firstChild->firstChild, $doc->firstChild);

which only works if <body> has only one child node, to this:

$domElements = $TMPDocument->getElementsByTagName('body')->item(0);
if( !empty($domElements) and $domElements->hasChildNodes() ){
    foreach ($domElements->childNodes as $child){
        $DOMDocument->appendChild($DOMDocument->importNode($child, true));
    }
}

and adding a wrapper function processTags to processTag handling the multiple instances.

Also, please add label to the textLevelElements array.

GrahamCampbell · 2015-04-07T15:23:34Z

ParsedownExtra.php

@@ -455,10 +455,28 @@ protected function parseAttributeData($attributeString)
        return $Data;
    }

+


ignores the list of voided elements when rendering markdown

Stabilizes library by revamping class to utilize methods from php 5.4 or greater.

Does an extra check on valid DOMElements to make sure they have child nodes before calling recursively.

GrahamCampbell reviewed Apr 7, 2015
View reviewed changes

ParsedownExtra.php

@@ -455,10 +455,28 @@ protected function parseAttributeData($attributeString)

return $Data;

}

Copy link

Contributor

GrahamCampbell Apr 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

acmitch added 4 commits April 7, 2015 11:37

Fixes Issue #44 & PHP Compatibility

b136d30

Ignore voided elements

468ecc6

ignores the list of voided elements when rendering markdown

Revamps utilization to require php >=5.4

77d0914

Stabilizes library by revamping class to utilize methods from php 5.4 or greater.

Fixes infinite loop issues

f20a4bc

Does an extra check on valid DOMElements to make sure they have child nodes before calling recursively.

acmitch changed the title ~~Fixes Issue #44 & PHP Compatibility~~ Fixes Issue #44 Jun 16, 2015

Lomanic mentioned this pull request Sep 15, 2015

DOMDocument::saveHTML() with $node parameter on php < 5.3.6 #75

Closed

Daniel-KM mentioned this pull request Jun 19, 2017

Fix and merge to release 0.8.0 #110

Open

damiani mentioned this pull request Mar 9, 2019

Update markdown parser and fix markup-in-markdown parsing error tighten/jigsaw#330

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes Issue #44 #58

Fixes Issue #44 #58

acmitch commented Apr 7, 2015

GrahamCampbell Apr 7, 2015

		@@ -455,10 +455,28 @@ protected function parseAttributeData($attributeString)
		return $Data;
		}

Fixes Issue #44 #58

Are you sure you want to change the base?

Fixes Issue #44 #58

Conversation

acmitch commented Apr 7, 2015

GrahamCampbell Apr 7, 2015

Choose a reason for hiding this comment