Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing.Rmd Line 15 Learn not to -> Learn how not to #34

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

stzv
Copy link
Collaborator

@stzv stzv commented Jun 13, 2024

Changed the learning objective from "Learn not to panic ..." to "Learn how not to panic ..."

Fixes #14

Changed the learning objective from "Learn not to panic ..." to "Learn how not to panic ..."
Copy link

github-actions bot commented Jun 13, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/DCC-Rpackaging-lesson/compare/md-outputs..md-outputs-PR-34

The following changes were observed in the rendered markdown documents:

 md5sum.txt | 2 +-
 testing.md | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-06-13 12:20:49 +0000

github-actions bot pushed a commit that referenced this pull request Jun 13, 2024
Copy link
Collaborator

@NeNo-hub NeNo-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stzv thanks for your effort, feel free to merge it!

@stzv stzv merged commit 5274296 into main Jun 13, 2024
3 checks passed
@stzv stzv deleted the stzv-patch-1 branch June 13, 2024 12:23
@stzv
Copy link
Collaborator Author

stzv commented Jun 13, 2024

Done and dusted.

github-actions bot pushed a commit that referenced this pull request Jun 13, 2024
Auto-generated via {sandpaper}
Source  : 5274296
Branch  : main
Author  : stzv <[email protected]>
Time    : 2024-06-13 12:23:43 +0000
Message : Merge pull request #34 from esciencecenter-digital-skills/stzv-patch-1

Update testing.Rmd Line 15 Learn not to -> Learn how not to
Reviewed by @NeNo-hub , thank you!
github-actions bot pushed a commit that referenced this pull request Jun 13, 2024
Auto-generated via {sandpaper}
Source  : 2e94bfc
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-13 12:24:39 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5274296
Branch  : main
Author  : stzv <[email protected]>
Time    : 2024-06-13 12:23:43 +0000
Message : Merge pull request #34 from esciencecenter-digital-skills/stzv-patch-1

Update testing.Rmd Line 15 Learn not to -> Learn how not to
Reviewed by @NeNo-hub , thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rephrase one of the lesson objectives in Testing episode
2 participants