Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

92 update vector episodes #105

Merged
merged 15 commits into from
Apr 30, 2024
Merged

Conversation

rogerkuou
Copy link
Collaborator

Fix #92

Copy link

github-actions bot commented Feb 28, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/geospatial-python/compare/md-outputs..md-outputs-PR-105

The following changes were observed in the rendered markdown documents:

 01-intro-raster-data.md                       |  62 ++--
 02-intro-vector-data.md                       |  30 +-
 03-crs.md                                     |  20 +-
 04-geo-landscape.md                           |  24 +-
 07-vector-data-in-python.md                   | 483 ++++++++++++--------------
 fig/E07/greece_administration_areas.png (new) | Bin 0 -> 64055 bytes
 fig/E07/greece_highways.png (new)             | Bin 0 -> 26479 bytes
 fig/E07/rhodes_administration_areas.png (new) | Bin 0 -> 17351 bytes
 fig/E07/rhodes_assets.png (new)               | Bin 0 -> 45400 bytes
 fig/E07/rhodes_builtup_buffer.png (new)       | Bin 0 -> 18396 bytes
 fig/E07/rhodes_highways.png (new)             | Bin 0 -> 80495 bytes
 fig/E07/rhodes_infra_highways.png (new)       | Bin 0 -> 46913 bytes
 md5sum.txt                                    |  10 +-
 13 files changed, 292 insertions(+), 337 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-04-30 12:10:15 +0000

github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
@Morrizzzzz
Copy link

I went though episode 1-4 and updated them in this branch.

@Morrizzzzz Morrizzzzz changed the base branch from main to draft_30042024 April 30, 2024 08:51
@Morrizzzzz Morrizzzzz marked this pull request as ready for review April 30, 2024 08:51
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
Copy link
Collaborator Author

@rogerkuou rogerkuou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Morrizzzzz, thanks for adding more changes. I made some comments here. And one more thing is to remove the data directory before merging, since the data are already uploaded to Figshare

episodes/04-geo-landscape.md Outdated Show resolved Hide resolved
episodes/04-geo-landscape.md Outdated Show resolved Hide resolved
episodes/03-crs.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@Morrizzzzz Morrizzzzz merged commit 9fa0400 into draft_30042024 Apr 30, 2024
2 checks passed
@Morrizzzzz Morrizzzzz deleted the 92_update_vector_episodes branch April 30, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update vector related episodes with new narratives
2 participants