Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added message to branch #94

Merged
merged 2 commits into from
Oct 6, 2023
Merged

added message to branch #94

merged 2 commits into from
Oct 6, 2023

Conversation

Morrizzzzz
Copy link

@Morrizzzzz Morrizzzzz commented Oct 3, 2023

Hi @rogerkuou

I just added an example, please do not merge yet, I will inform you when it is.

I am going to work on:

  • add narrative
  • rerun the code

Cheers, Maurice

github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/geospatial-python/compare/md-outputs..md-outputs-PR-94

The following changes were observed in the rendered markdown documents:

 md5sum.txt         |  3 +-
 narrative.md (new) | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 setup.md           |  2 +-
 3 files changed, 90 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-10-03 15:26:06 +0000

github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
@Morrizzzzz
Copy link
Author

@rogerkuou

Great work!

I just added a some text in the notebook and went through all the steps. One minor comment, now that I also looked a little in the literature I changed forest fires into wild fires, which is basically the "parent" of forest fires.

Furthermore I was wondering why we are projecting it and then undo that? In every GIS project I would always first allign all my data to a projected coordinate system. Also (out of habit) I try to project it as UTM data.

I guess my PR is now ready for review! ;-)

@Morrizzzzz Morrizzzzz marked this pull request as ready for review October 3, 2023 15:31
@rogerkuou
Copy link
Collaborator

@Morrizzzzz Thanks! The text looks awesome. They can be quite useful when we update the course curriculum later. I will merge it now.

@rogerkuou rogerkuou merged commit e5758fd into vector_eps Oct 6, 2023
2 checks passed
@rogerkuou rogerkuou mentioned this pull request Oct 6, 2023
@rogerkuou rogerkuou deleted the vector_narrative_added branch October 6, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants