Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to NEBULA slides instead of Olgas slides #24

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

svenvanderburg
Copy link
Contributor

Fixes #22

Copy link

github-actions bot commented Sep 16, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/good-practices-lesson/compare/md-outputs..md-outputs-PR-24

The following changes were observed in the rendered markdown documents:

 1-modular-code.md  | 2 +-
 2-documentation.md | 2 +-
 3-testing.md       | 2 ++
 4-ci.md            | 2 +-
 md5sum.txt         | 8 ++++----
 5 files changed, 9 insertions(+), 7 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-09-16 13:39:51 +0000

github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
Copy link
Contributor

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svenvanderburg Looks good. It can be merged now. I shall review slides separately and archive older repo.

@svenvanderburg svenvanderburg merged commit 230b658 into main Sep 23, 2024
3 checks passed
@svenvanderburg svenvanderburg deleted the refer-to-nebula-slides branch September 23, 2024 09:27
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
Auto-generated via {sandpaper}
Source  : 230b658
Branch  : main
Author  : Sven van der Burg <[email protected]>
Time    : 2024-09-23 09:27:16 +0000
Message : Merge pull request #24 from esciencecenter-digital-skills/refer-to-nebula-slides

Refer to NEBULA slides instead of Olgas slides
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
Auto-generated via {sandpaper}
Source  : 69d1da9
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-23 09:28:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 230b658
Branch  : main
Author  : Sven van der Burg <[email protected]>
Time    : 2024-09-23 09:27:16 +0000
Message : Merge pull request #24 from esciencecenter-digital-skills/refer-to-nebula-slides

Refer to NEBULA slides instead of Olgas slides
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Auto-generated via {sandpaper}
Source  : 69d1da9
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-23 09:28:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 230b658
Branch  : main
Author  : Sven van der Burg <[email protected]>
Time    : 2024-09-23 09:27:16 +0000
Message : Merge pull request #24 from esciencecenter-digital-skills/refer-to-nebula-slides

Refer to NEBULA slides instead of Olgas slides
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Auto-generated via {sandpaper}
Source  : 69d1da9
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-23 09:28:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 230b658
Branch  : main
Author  : Sven van der Burg <[email protected]>
Time    : 2024-09-23 09:27:16 +0000
Message : Merge pull request #24 from esciencecenter-digital-skills/refer-to-nebula-slides

Refer to NEBULA slides instead of Olgas slides
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
Auto-generated via {sandpaper}
Source  : 69d1da9
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-23 09:28:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 230b658
Branch  : main
Author  : Sven van der Burg <[email protected]>
Time    : 2024-09-23 09:27:16 +0000
Message : Merge pull request #24 from esciencecenter-digital-skills/refer-to-nebula-slides

Refer to NEBULA slides instead of Olgas slides
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
Auto-generated via `{sandpaper}`
Source  : 69d1da9
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-23 09:28:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 230b658
Branch  : main
Author  : Sven van der Burg <[email protected]>
Time    : 2024-09-23 09:27:16 +0000
Message : Merge pull request #24 from esciencecenter-digital-skills/refer-to-nebula-slides

Refer to NEBULA slides instead of Olgas slides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update instructor notes after migrating slides
2 participants