Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation episode #3

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

svenvanderburg
Copy link
Contributor

Copy link

github-actions bot commented Jun 3, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/good-practices-lesson/compare/md-outputs..md-outputs-PR-3

The following changes were observed in the rendered markdown documents:

 2-documentation.md (new) | 247 +++++++++++++++++++++++++++++++++++++++++++++++
 config.yaml              |   1 +
 md5sum.txt               |   3 +-
 3 files changed, 250 insertions(+), 1 deletion(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-06-03 14:51:28 +0000

github-actions bot pushed a commit that referenced this pull request Jun 3, 2024
Copy link
Contributor

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svenvanderburg. Looks great. Can you please check the following GitHub Actions messages:
[missing file]: PyTest
[image missing alt-text]: fig/ci-python-application-workflow.png and
[image missing alt-text]: fig/ci-tests-succeed-screenshot.png

@svenvanderburg
Copy link
Contributor Author

@lyashevska yes, there are indeed missing alt-texts. But since this lesson material is only for internal use I think we don't really care about those details.

@svenvanderburg svenvanderburg merged commit f26f866 into main Jun 4, 2024
3 checks passed
@svenvanderburg svenvanderburg deleted the add-documentation-episode branch June 4, 2024 12:08
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : f26f866
Branch  : main
Author  : Sven van der Burg <[email protected]>
Time    : 2024-06-04 12:08:35 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/add-documentation-episode

Add documentation episode
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : e85205e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-04 12:09:51 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f26f866
Branch  : main
Author  : Sven van der Burg <[email protected]>
Time    : 2024-06-04 12:08:35 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/add-documentation-episode

Add documentation episode
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
Auto-generated via {sandpaper}
Source  : e85205e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-04 12:09:51 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f26f866
Branch  : main
Author  : Sven van der Burg <[email protected]>
Time    : 2024-06-04 12:08:35 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/add-documentation-episode

Add documentation episode
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
Auto-generated via {sandpaper}
Source  : e85205e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-04 12:09:51 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f26f866
Branch  : main
Author  : Sven van der Burg <[email protected]>
Time    : 2024-06-04 12:08:35 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/add-documentation-episode

Add documentation episode
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
Auto-generated via {sandpaper}
Source  : e85205e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-04 12:09:51 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f26f866
Branch  : main
Author  : Sven van der Burg <[email protected]>
Time    : 2024-06-04 12:08:35 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/add-documentation-episode

Add documentation episode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Documentation to the new workbench lesson
2 participants