Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise episodes 1 through 9 for readability #13

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

wmotion
Copy link

@wmotion wmotion commented Jun 30, 2023

This PR contains various edits to improve the reading experience: for example, more active verb forms, fewer antecedent/consequent pairs. The correctness/appropriateness of the words is left out of discussion here, hence I tried not to alter that.

@jhidding In this revision of introduction.md, each sentence takes a new line. If this makes reviewing the merge cumbersome, I can split the PRs into one that contains edits in the original line layout; and into a following one that only breaks lines, once a final(ish) text has been agreed.

Linguistic interventions to improve readability, while affecting the current meanings as little as possible.
introduction.md: readability pass 1
It makes it so much more readable and improvable
Enforce consistent (not necessarily correct) punctuation. 
Apply occasional edits.
introduction.md: incorporate edits for readability
@github-actions
Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files or spoofing.

It should be safe to Approve and Run the workflows that need maintainer approval.

Linguistic interventions to improve readability, affecting the current meanings as little as possible.
benchmarking.md: readability pass 1
@wmotion wmotion changed the title Revise episode introduction.md for readability Revise episodes introduction+benchmarking for readability Jun 30, 2023
@wmotion wmotion changed the title Revise episodes introduction+benchmarking for readability Revise episodes 1,2,3 for readability Jun 30, 2023
@wmotion wmotion changed the title Revise episodes 1,2,3 for readability Revise episodes 1,2,3,4 for readability Jun 30, 2023
@wmotion wmotion changed the title Revise episodes 1,2,3,4 for readability Revise episodes 1,2,3,4,5 for readability Jun 30, 2023
@wmotion wmotion changed the title Revise episodes 1,2,3,4,5 for readability Revise episodes 1 through 6 for readability Jul 1, 2023
@wmotion wmotion changed the title Revise episodes 1 through 6 for readability Revise episodes 1 through 7 for readability Jul 1, 2023
@wmotion wmotion changed the title Revise episodes 1 through 7 for readability Revise episodes 1 through 8 for readability Jul 1, 2023
@wmotion
Copy link
Author

wmotion commented Jul 1, 2023

This comment marks the end of the first round of checks for readability.

@wmotion
Copy link
Author

wmotion commented Jul 1, 2023

This comment marks the end of the second round of checks for readability. The sentences should be less conversational and tighter now, hence easier to read through. During the revision I kept in mind common-sense practices in scientific writing (and time efficiency).

I restricted myself to textual clarity. As for the content, the depth, breadth and position of topics are unchanged. I did not evaluate the correctness and consistency of content and the pedagogy of the exposition. Hopefully, the current edits can serve well enough for the coming edition of 5-6 4-5 June.

In general, I aimed to have each commit deal with changes in a single md file. The diffs of all nine files affected by this PR are at https://github.com/esciencecenter-digital-skills/parallel-python-workbench/pull/13/files

Hope this helps.

@jhidding

See help(memory_usage) for the memory being measured in MiB.
Fill gaps. Fix NameError with variable `high`.
Incorporate changes from the source repository
@wmotion wmotion marked this pull request as draft July 3, 2023 11:31
@wmotion wmotion marked this pull request as ready for review July 3, 2023 11:43
@wmotion
Copy link
Author

wmotion commented Jul 3, 2023

@jhidding
Seen that we are working within a limited time frame, feel free to review this PR at any time.
I am working file-wise following the lesson order anyhow. I can make another PR for the files remaining after the review.
Also, let me know if pulling into main turns out (has turned out) to be inconvenient for you.

Copy link
Collaborator

@jhidding jhidding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't thank you enough Giordano! This is great work. I only have a few slight remarks.

episodes/benchmarking.md Outdated Show resolved Hide resolved
episodes/benchmarking.md Show resolved Hide resolved
episodes/computing-pi.md Outdated Show resolved Hide resolved
episodes/delayed-evaluation.md Outdated Show resolved Hide resolved
episodes/delayed-evaluation.md Outdated Show resolved Hide resolved
episodes/map-and-reduce.md Outdated Show resolved Hide resolved
episodes/threads-and-processes.md Outdated Show resolved Hide resolved
episodes/threads-and-processes.md Show resolved Hide resolved
episodes/threads-and-processes.md Outdated Show resolved Hide resolved
episodes/threads-and-processes.md Outdated Show resolved Hide resolved
Copy link
Author

@wmotion wmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detailed remarks under each review point. Thanks for your feedback.

@wmotion wmotion requested a review from jhidding July 3, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants