Infinite loop fix #722
Open
Infinite loop fix #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t color newly created tool bar tint color will be default and not the one u set. Not sure when is actually applied and are other elements affected, but to apply to prev next segmented control application color theme _prevNext.tintColor should be set from [UIToolbar appearance].tintColor instead of UIToolbar actionBar object tintColor property as it is not set at that moment
iOS 9 calls reloadData less agressively than iOS 8 and earlier. If the root of the table view is set too soon (eg. before the data source is set), reloadData may not be called in certain cases, resulting in inconsistencies and inducing crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for infinite loop for QPickerTableViewCell
Also... Regarding previous commit that u rejected few years ago... Couldn't find a way to remove it from fork, and I still think u should merge it. I am not setting global toolbar appearance there. Just making sure that segmented control is colored with expected UIToolbar color from appearance settings.