feat: add timeout support (#733)

eshaham · Nov 3, 2022 · 4dc3e69 · 4dc3e69
1 parent 40efeee
commit 4dc3e69
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/scrapers/base-scraper-with-browser.ts b/src/scrapers/base-scraper-with-browser.ts
@@ -138,6 +138,7 @@ class BaseScraperWithBrowser extends BaseScraper {
     } else {
       const executablePath = this.options.executablePath || undefined;
       const args = this.options.args || [];
+      const { timeout } = this.options;
 
       const headless = !this.options.showBrowser;
       debug(`launch a browser with headless mode = ${headless}`);
@@ -146,6 +147,7 @@ class BaseScraperWithBrowser extends BaseScraper {
         headless,
         executablePath,
         args,
+        timeout,
       });
     }
 

diff --git a/src/scrapers/base-scraper.ts b/src/scrapers/base-scraper.ts
@@ -91,6 +91,12 @@ export interface ScraperOptions {
    */
   args?: string[];
 
+  /**
+   * Maximum navigation time in milliseconds, pass 0 to disable timeout.
+   * @default 30000
+   */
+  timeout?: number | undefined;
+
   /**
    * adjust the browser instance before it is being used
    *