feat: fetch credit card line of credit utilization #857
Conversation
Optional feature to fetch credit card line of credit utilization and limit.
| interface AccountCredit { | ||
| creditUtilization: number; | ||
| creditLimit: number; | ||
| } |
There was a problem hiding this comment.
I think you can declare this interface once in transactions.ts and import it everywhere.
There was a problem hiding this comment.
I though about that too, but as this is an internal type (it's used locally, not "passed" outside the file) I opted into this.
If you think otherwise - let me know.
| if (creditUtilization && creditUtilization[accountNumber]) { | ||
| account.credit = { | ||
| creditUtilization: creditUtilization[accountNumber].creditUtilization, | ||
| creditLimit: creditUtilization[accountNumber].creditLimit, | ||
| }; | ||
| } |
There was a problem hiding this comment.
What do you think about this?
| if (creditUtilization && creditUtilization[accountNumber]) { | |
| account.credit = { | |
| creditUtilization: creditUtilization[accountNumber].creditUtilization, | |
| creditLimit: creditUtilization[accountNumber].creditLimit, | |
| }; | |
| } | |
| account.credit = creditUtilization?.[accountNumber]; |
- The
creditUtilization[accountNumber]structure is the same as theaccount.credit. Even if it isnullorundefinedit is OK because we accept no response for some accounts.
There was a problem hiding this comment.
Looks like a better idea, Will update.
| async function fetchCreditUtilization( | ||
| page: Page, | ||
| servicesUrl: string, | ||
| ): Promise<_.Dictionary<AccountCredit> | null> { |
There was a problem hiding this comment.
Please use standard types, I'm not familiar with lodash types, I can't understand them from the tooltip and I don't expect other contributors to understand it.
There was a problem hiding this comment.
As lodash is already installed on the project I believed it's OK.
Will change
There was a problem hiding this comment.
You're right, although I'm thinking a lot before I add lodash to a project, if it is already there I accept using it.
But still, for the function signature, which is a kind of contract/interface, I prefer to use standard types.
|
Please pull the latest changes from |
@baruchiro good idea, done 👍 |
|
@baruchiro I commented on the previous PR saying I will replace it right after I've opened it, the reason is I accidentally committed from my company's account, this is why I needed a new PR from my personal account. |
|
Pull request has been marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Optional feature to fetch credit card line of credit utilization and limit.
Initial support for Isracard-amex, Cal, Max.
This is a replacement PR of #795.
The main changes from #795:
Sorry for the long delay doing this, hope this answers your concerns and we can merge :)