Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: otsar inherit beinleumi bank #885

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kapel2208
Copy link

Changes:

  • Otsar Hayal scraper inherit BeinleumiBase (similar to Masad and Beinleumi)
  • Remove previous Otsar Hayal code (duplicate from beinleumi)
  • Bugfix on Otsar scraping, the hasNextPage loop got wrong. Issue does not exist on base scraper.

@kapel2208 kapel2208 changed the title Otsar inherit beinleumi bank feat: otsar inherit beinleumi bank Oct 19, 2024
@baruchiro
Copy link
Collaborator

@matanelgabsi can you test this?

@baruchiro
Copy link
Collaborator

@kapel2208 do you want to be registered as a tester for Otsar Hachaial here: #830?

@kapel2208
Copy link
Author

@kapel2208 do you want to be registered as a tester for Otsar Hachaial here: #830?

Yes, no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants