-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-28:Upgrade Cantaloupe to 5.0.4 #29
Conversation
…raphicsMagick since it's no longer supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes to make this more portable. Also lines 56 and 66 need updates on the comments. Thanks a lot!!
Oh, right. Because of the multiplatform thing. I you look at the old (pre
4.19) docker file i used to start with an alpine linux base box…. Ok. That
basically means that base box has a user 100 and there is nothing we can
do… so we stick to 1000 and change docs? Thx sorry I’m really distracted
On Sat, Oct 16, 2021 at 2:18 PM Albert Min ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In esmero-cantaloupe/Dockerfile
<#29 (comment)>
:
> && cd /usr/local \
- && unzip cantaloupe-4.1.10-SNAPSHOT.zip \
- && ln -s cantaloupe-4.1.10-SNAPSHOT cantaloupe \
- && rm -rf /tmp/4.1.zip \
- && rm -rf /usr/local/cantaloupe-4.1.10-SNAPSHOT.zip \
- && rm -rf /usr/local/cantaloupe-release-4.1 \
+ && unzip cantaloupe-5.0.4.zip \
+ && ln -s cantaloupe-5.0.4 cantaloupe \
+ && rm -rf /tmp/5.0.zip \
+ && rm -rf /usr/local/cantaloupe-release-5.0.zip \
+ && rm -rf /usr/local/cantaloupe-release-5.0 \
Step 19/29 : RUN adduser -u 100 --home $home $user
---> Running in d0faa2997224
adduser: The UID 100 is already in use.
The command '/bin/sh -c adduser -u 100 --home $home $user' returned a non-zero code: 1
Is there maybe some kind of upstream change on UIDs? Checking on a built
container without setting the UID shows it's taken by _apt:
_apt:x:100:65534::/nonexistent:/usr/sbin/nologin.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABU7ZZ6J4IMBSYY2DIIIJ63UHG6XHANCNFSM5GAETUPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Diego Pino Navarro
Digital Repositories Developer
Metropolitan New York Library Council (METRO)
|
No worries @DiegoPino . We could also change the UID and GID for the user and group that are getting auto-assigned 100 (
|
@aksm can you please check and update if needed We need to be sure we provide a default cantaloupe.propertie files that works with this release. This will also need to happen on archipelago-deployment and deployment-live. But once I build and push this container. Thanks |
@DiegoPino All set!
|
Obviated by #38 |
Upgrade Cantaloupe to 5.0.4 as described here. One part of this PR not included in the issue is the installation of TurboJpegProcessor, which should adds a performance boost for JPEG reading/writing, as described in the docs. GraphicsMagick/ImageMagick has also been removed since it's no longer supported (see issue).
Resolves #28