Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-28:Upgrade Cantaloupe to 5.0.4 #29

Closed
wants to merge 3 commits into from
Closed

ISSUE-28:Upgrade Cantaloupe to 5.0.4 #29

wants to merge 3 commits into from

Conversation

aksm
Copy link

@aksm aksm commented Oct 14, 2021

Upgrade Cantaloupe to 5.0.4 as described here. One part of this PR not included in the issue is the installation of TurboJpegProcessor, which should adds a performance boost for JPEG reading/writing, as described in the docs. GraphicsMagick/ImageMagick has also been removed since it's no longer supported (see issue).

Resolves #28

…raphicsMagick since it's no longer supported.
@aksm aksm added enhancement New feature or request esmero-cantaloupe IIIF goodness in docker package labels Oct 14, 2021
@aksm aksm requested a review from DiegoPino October 14, 2021 17:10
@aksm aksm self-assigned this Oct 14, 2021
Copy link
Member

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes to make this more portable. Also lines 56 and 66 need updates on the comments. Thanks a lot!!

esmero-cantaloupe/Dockerfile Show resolved Hide resolved
esmero-cantaloupe/Dockerfile Outdated Show resolved Hide resolved
esmero-cantaloupe/Dockerfile Outdated Show resolved Hide resolved
esmero-cantaloupe/Dockerfile Outdated Show resolved Hide resolved
@DiegoPino DiegoPino changed the title Upgrade Cantaloupe to 5.0.4 ISSUE-28:Upgrade Cantaloupe to 5.0.4 Oct 15, 2021
@DiegoPino
Copy link
Member

DiegoPino commented Oct 16, 2021 via email

@aksm
Copy link
Author

aksm commented Oct 18, 2021

No worries @DiegoPino . We could also change the UID and GID for the user and group that are getting auto-assigned 100 (_apt and users). Just tested in the build by assigning 1000 to both, and it seems to work fine.

Oh, right. Because of the multiplatform thing. I you look at the old (pre 4.19) docker file i used to start with an alpine linux base box…. Ok. That basically means that base box has a user 100 and there is nothing we can do… so we stick to 1000 and change docs? Thx sorry I’m really distracted
On Sat, Oct 16, 2021 at 2:18 PM Albert Min @.> wrote: @.* commented on this pull request. ------------------------------ In esmero-cantaloupe/Dockerfile <#29 (comment)> : > && cd /usr/local \ - && unzip cantaloupe-4.1.10-SNAPSHOT.zip \ - && ln -s cantaloupe-4.1.10-SNAPSHOT cantaloupe \ - && rm -rf /tmp/4.1.zip \ - && rm -rf /usr/local/cantaloupe-4.1.10-SNAPSHOT.zip \ - && rm -rf /usr/local/cantaloupe-release-4.1 \ + && unzip cantaloupe-5.0.4.zip \ + && ln -s cantaloupe-5.0.4 cantaloupe \ + && rm -rf /tmp/5.0.zip \ + && rm -rf /usr/local/cantaloupe-release-5.0.zip \ + && rm -rf /usr/local/cantaloupe-release-5.0 \ Step 19/29 : RUN adduser -u 100 --home $home $user ---> Running in d0faa2997224 adduser: The UID 100 is already in use. The command '/bin/sh -c adduser -u 100 --home $home $user' returned a non-zero code: 1 Is there maybe some kind of upstream change on UIDs? Checking on a built container without setting the UID shows it's taken by _apt: _apt100:65534::/nonexistent:/usr/sbin/nologin. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABU7ZZ6J4IMBSYY2DIIIJ63UHG6XHANCNFSM5GAETUPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Diego Pino Navarro Digital Repositories Developer Metropolitan New York Library Council (METRO)

@aksm aksm requested a review from DiegoPino October 18, 2021 23:19
@DiegoPino
Copy link
Member

@aksm can you please check and update if needed
https://github.com/esmero/archipelago-docker-images/blob/main/esmero-cantaloupe/cantaloupe.properties for this pull too?

We need to be sure we provide a default cantaloupe.propertie files that works with this release. This will also need to happen on archipelago-deployment and deployment-live. But once I build and push this container. Thanks

@aksm
Copy link
Author

aksm commented Oct 19, 2021

@DiegoPino All set!

@aksm can you please check and update if needed https://github.com/esmero/archipelago-docker-images/blob/main/esmero-cantaloupe/cantaloupe.properties for this pull too?

We need to be sure we provide a default cantaloupe.propertie files that works with this release. This will also need to happen on archipelago-deployment and deployment-live. But once I build and push this container. Thanks

@aksm
Copy link
Author

aksm commented Jun 28, 2022

Obviated by #38

@aksm aksm closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request esmero-cantaloupe IIIF goodness in docker package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Cantaloupe to 5.0.4
2 participants