Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-463: The ADO to ADO JOIN filter #464

Merged
merged 23 commits into from
Oct 8, 2024
Merged

ISSUE-463: The ADO to ADO JOIN filter #464

merged 23 commits into from
Oct 8, 2024

Commits on Aug 22, 2024

  1. Improve Ajax/Facet/Views update interactions & Controller

    Filters the theme and ajax page state from the query, better checking if something is actually there and successfully updated, etc.
    DiegoPino committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    3f13235 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18386eb View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. First attempt on updating arguments on other views that are not facet…

    … driven
    
    The idea here is that we also collect for all facets the other views present in the page and if they have pagers we also (not sure yet how) do a "refresh" either partial (reloading the attached behavior for the paging) or complete (easier but also more server intensive?) to make sure the facet selection does not get lost between paging but also the page itself (*current one) is re-used for those views so the view does not fully fully reset .
    
    @alliomeria more to come. Not ready yet
    DiegoPino committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ab773da View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Configuration menu
    Copy the full SHA
    c777654 View commit details
    Browse the repository at this point in the history
  2. use new for 10.3 renderInIsolation()

    Persist session and ajax page state too (breaking also in 10.3, facets actually need to be manually patched or will also break on ajax)
    DiegoPino committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    423233f View commit details
    Browse the repository at this point in the history
  3. In the case reset makes it to ajax, at least remove some of the argum…

    …ents
    
    This can be better though
    DiegoPino committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    cafe17d View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Adds #search/term reaction to Mirador to Match Bookreader one

    Another commit will also mimic back (update) the hash when people decide to search from 0 or again.
    DiegoPino committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d6e28fd View commit details
    Browse the repository at this point in the history
  2. Only act on fragment change on mirador if there is a new search

    That way navigating between canvases won't break the URL
    DiegoPino committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    527d9cd View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. First pass on ADO to ADO filter

    I need to still figure out if "flexibility" here is more important than speed. Why?
    I can save (as in the code) the Solr Field name exactly the way i need if for the JOIN (or multiple) by allowing the Settings to use that instead of the Search API one, but... if the user decides to re-index an already setup field by changing the type the filter will break. But also, having to calculate the proper Solr name on every query is expensive. What will it be, what @alliomeria ?
    DiegoPino committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    732cf40 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    fa0b3f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4951d26 View commit details
    Browse the repository at this point in the history
  3. Allow any View to opt out of setting (via Ajax) the Browser URL

    When using Archipelago and Ajax views. Why? @alliomeria pleas read:
    If you have more than one view on a screen, and if some views are loading automatically via Ajax (and/or depend on arguments of another) each one will compete for adding their own arguments to the Browser, breaking e.g an initial search set by the page level one. This new setting can be found under Advanced, Ajax. It is an opt out one, so people already using this don't need to change anything
    DiegoPino committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    54e264e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8fc193e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Join was omitting fields

    Need to test more. Not ready yet
    DiegoPino committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9b85aea View commit details
    Browse the repository at this point in the history
  2. Allow the source NODE ID to be selected to

    I did not count for the mutliple indexes option, and fixed it to its_nid ... bad boy here @alliomeria
    DiegoPino committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    adf755b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    663ceea View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    11fa9bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3942215 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Clean some code/routes we don't need anymore.

    Allow a dynamic loading View to also act on resets (which was hard gosh)
    DiegoPino committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1ed525c View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    e5f16d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. More fixes for reset

    DiegoPino committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e227456 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Damn. Not every theme has a #main element

    Try also with #main-content and if not, give up
    DiegoPino committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c029c57 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. make sure we state this needs Drupal 10.3+

    Why? Deprecations and in specific the renderInIsolation new method (Drupal!!)
    DiegoPino committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    83e901f View commit details
    Browse the repository at this point in the history