Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ap:tasks entry to define what JSON key can alternatively (other than label) drive the NODE title #261

Open
DiegoPino opened this issue Mar 27, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request Events and Subscriber JMESPath a.*.wonderful.life[0] JSON Preprocessors Drupal Plugins that do stuff before JSON data is saved and can shape it
Milestone

Comments

@DiegoPino
Copy link
Member

DiegoPino commented Mar 27, 2023

What?

So far we have fixed that label key will drive always an ADO/NODE title. There are times (specially on multiligual Repositories) when we want to make one exception. ap:tasks is the key for machinable instruction to be given to Archipelago.

This ISSUE will support code that will provide

"ap:tasks": {
        "ap:entitytitle": "JMESPATHEXPRESSION"
    }

I'm keeping a lowercase no _ nomenclature for these keys but happy to revision this @alliomeria @aksm if you think we should use CamelCase or _ for this key.

The code will modify a few lines here
https://github.com/esmero/strawberryfield/blob/78f4bdb5ca57e522e85c139c3db99ca6cebdd728/src/EventSubscriber/StrawberryfieldEventPresaveSubscriberSetTitlefromMetadata.php

Thanks

@DiegoPino DiegoPino added enhancement New feature or request JSON Preprocessors Drupal Plugins that do stuff before JSON data is saved and can shape it Events and Subscriber JMESPath a.*.wonderful.life[0] labels Mar 27, 2023
@DiegoPino DiegoPino added this to the 1.1.0 milestone Mar 27, 2023
@DiegoPino DiegoPino self-assigned this Mar 27, 2023
@alliomeria
Copy link
Contributor

Sounds great, thank you @DiegoPino! Lowercase approach makes sense to me too.

@DiegoPino
Copy link
Member Author

Thanks @alliomeria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Events and Subscriber JMESPath a.*.wonderful.life[0] JSON Preprocessors Drupal Plugins that do stuff before JSON data is saved and can shape it
Projects
None yet
Development

No branches or pull requests

2 participants