ISSUE-261: Adds ap:tasks title source option #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g
```JSON
{
"type": "DataSet",
"label": "Title from metadata",
"label_spa": "Título desde metadatos",
"ap:tasks" {
"ap:entitytitle": "label_spa"
}
}
```
Will yield in an ADO/NODE with title "Título desde metadatos"
In case of a wrong JMESPATH expression the original title will be preserved (if existing) or the default label key will be used.
aksm
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
@DiegoPino did some basic testing and looked for any obvious problems, but didn't want to hold things up so kept it light. Glad to review more thoroughly if needed though. Looks great on first pass!
|
Thanks @aksm ! Really appreciate the speed on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #261
e.g
{ "type": "DataSet", "label": "Title from metadata", "label_spa": "Título desde metadatos", "ap:tasks" { "ap:entitytitle": "label_spa" } }Will yield in an ADO/NODE with title "Título desde metadatos". In case of a wrong JMESPATH expression the original title will be preserved (if existing) or the default label key will be used.