Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embassy: introduce InterruptExecutor::spawner() #1211

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

kaspar030
Copy link
Contributor

@kaspar030 kaspar030 commented Feb 28, 2024

This PR adds InterruptExecutor::spawner() to match the corresponding change to embassy.

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

@kaspar030
Copy link
Contributor Author

kaspar030 commented Feb 28, 2024

I think the linting issue is unrelated:

warning: the item `proc_macro` is imported redundantly
 --> /home/runner/work/esp-hal/esp-hal/esp-hal-procmacros/src/interrupt.rs:1:18
  |
1 | use proc_macro::{self, TokenStream};
  |                  ^^^^ the item `proc_macro` is already defined here
  |
  = note: `#[warn(unused_imports)]` on by default

edit yup, looks like #1210.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a nice addition. I'm sorry but we just merged some other PRs which has introduced a conflict, would you mind rebasing?

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've resolved the conflict, so this LGTM. Thanks for the contribution!

(We're having some CI issues, clippy-riscv will fail, that's fine!)

@jessebraham jessebraham added this pull request to the merge queue Feb 28, 2024
Merged via the queue into esp-rs:main with commit 3ec0f3b Feb 28, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants