Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uart init #1213

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Uart init #1213

merged 5 commits into from
Feb 28, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 28, 2024

Fixes #1195 - doesn't include P4 since we don't have UART for P4, yet. Should be part of the driver implementation for that chip

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Feb 28, 2024 •
edited
Loading

Clippy fails because of #1210

MabezDev
MabezDev requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! I have a couple of comments regarding maintainability but those should be easy to address.

I will also do a couple of tests with the flasher stub to make sure we didn't break anything there.

esp-hal/src/uart.rs Outdated Show resolved Hide resolved
esp-hal/src/uart.rs Outdated Show resolved Hide resolved
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Feb 28, 2024

I will also do a couple of tests with the flasher stub to make sure we didn't break anything there.

Oh, that's good - somehow forgot about the flasher stub

MabezDev
MabezDev approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, and thanks for addressing the comments! I tested in flasher stub and all looks good there (will send a esp-hal upgrade PR shortly).

@bjoernQ bjoernQ merged commit 12176db into esp-rs:main Feb 28, 2024
17 of 18 checks passed
@bjoernQ bjoernQ deleted the uart-init branch February 28, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve uart-init for chips other than ESP32-C3
2 participants
@bjoernQ @MabezDev